Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have UnsubscriptionError log something nicer to console #1590

Closed
benlesh opened this issue Apr 7, 2016 · 3 comments
Closed

Have UnsubscriptionError log something nicer to console #1590

benlesh opened this issue Apr 7, 2016 · 3 comments
Assignees
Labels
feature PRs and issues for features

Comments

@benlesh
Copy link
Member

benlesh commented Apr 7, 2016

RxJS version: 5.0.0-beta.5

Code to reproduce:

const source1 = Observable.create(() => () => { throw new Error('I am an error'); });
const source2 = Observable.timer(1000);
const source3 = Observable.create(() => () => { throw new Error('I am another error'); });
const source = source1.merge(source2, source3);

const subscription = source.subscribe();

subscription.unsubscribe();

Expected behavior:

Console logs out something readable to the effect of UnsubscriptionError: 1) Error: I am an error 2) Error: I am another error.

Actual behavior:

Console only logs out UnsubscriptionError. User is expect to catch it an analyze the errors property to glean information.

Additional information:

Ideally we could even link additional information about what an Unsubscription error is.

Important note for the example above. source2 should still be torn down.

@benlesh benlesh added feature PRs and issues for features priority: high labels Apr 7, 2016
@benlesh
Copy link
Member Author

benlesh commented Apr 7, 2016

cc/ @juliemr for visibility and additional information or desires around this functionality.

@juliemr
Copy link

juliemr commented Apr 7, 2016

Thanks! The readable console log would be great, it would have sped up my recent debugging incident.

@benlesh benlesh closed this as completed in dd01279 Apr 9, 2016
staltz pushed a commit to staltz/RxJSNext that referenced this issue Apr 13, 2016
…essage

- Adds improved console logging behavior

closes ReactiveX#1590
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature PRs and issues for features
Projects
None yet
Development

No branches or pull requests

2 participants