Error on complete when using .bufferTime().take() and supplying a maxBufferSize

[sbm007]

RxJS version:
[email protected]

Code to reproduce:
jsbin example

Rx.Observable.interval(100)
  .bufferTime(1000, null, 5)
  .take(5)
  .subscribe(console.log.bind(console.log));

Expected behavior:
Stream should complete without any errors.

Actual behavior:
Throws a TypeError on complete:

Uncaught TypeError: Cannot read property 'push' of null
    BufferTimeSubscriber.openContext @ Rx.js:6288
    BufferTimeSubscriber.onBufferFull @ Rx.js:6280
    BufferTimeSubscriber._next @ Rx.js:6256
    Subscriber.next @ Rx.js:1301

Additional information:

• This bug only occurs when supplying a maxBufferSize and using a bufferCreationInterval of null.
• Looking at the code the problem is quite obvious, need to guard this.contexts in BufferTimeSubscriber.prototype.openContext
• Very similar to issue Error on complete when using .bufferTime().take() #1763 / PR fix(bufferTime): handle closing context when synchronously unsubscribed #1764

[kwonoj]

Thanks for report. as I did similar changes to guard, let me take a look at this as well.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.