Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comprehensive marble tests for buffer #381

Closed
benlesh opened this issue Sep 23, 2015 · 4 comments
Closed

Comprehensive marble tests for buffer #381

benlesh opened this issue Sep 23, 2015 · 4 comments
Assignees
@staltz
Labels
help wanted Issues we wouldn't mind assistance with.
Milestone
Initial Beta

Comments

@benlesh
Copy link
Member

benlesh commented Sep 23, 2015

Should duplicate the current RxJS 3/4 tests

Should adhere to our contribution guidelines and operator authoring docs.
@benlesh benlesh added help wanted Issues we wouldn't mind assistance with. and removed help wanted Issues we wouldn't mind assistance with. labels Sep 23, 2015
@benlesh benlesh modified the milestone: Initial Beta Sep 23, 2015
@staltz
Copy link
Member

staltz commented Oct 7, 2015

Should not yet be closed.

Tests from RxJS 3/4 are mostly covered. Just a few still missing.

@staltz
Copy link
Member

staltz commented Oct 13, 2015

I can this one.

@staltz staltz mentioned this issue Oct 14, 2015
Closed
staltz pushed a commit to staltz/RxJSNext that referenced this issue Oct 14, 2015
fix(Subject): fix missing unsubscribe call
3730736 
Fix a bug manifested when running the test
'Observable.prototype.bufferWhen should emit buffers using varying hot
closings'. These changes are important to make unsubscriptions appear
for that test.

Relates to ReactiveX#381.
@staltz staltz mentioned this issue Oct 14, 2015
Closed
@benlesh benlesh closed this as completed Oct 14, 2015
benlesh pushed a commit that referenced this issue Oct 14, 2015
@benlesh
fix(Subject): fix missing unsubscribe call
9dd27d6 
Fix a bug manifested when running the test
'Observable.prototype.bufferWhen should emit buffers using varying hot
closings'. These changes are important to make unsubscriptions appear
for that test.

Relates to #381.
@benlesh
Copy link
Member Author

benlesh commented Oct 14, 2015

Looks like bufferToggle is the last one on this list requiring tests.

@staltz
Copy link
Member

staltz commented Oct 14, 2015

Yep

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@staltz staltz

Labels
help wanted Issues we wouldn't mind assistance with.
Projects
None yet
Milestone
Initial Beta
Development

No branches or pull requests
2 participants
@staltz @benlesh