Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dtslint for better type expectations #3823

Closed
cartant opened this issue Jun 10, 2018 · 0 comments
Closed

Use dtslint for better type expectations #3823

cartant opened this issue Jun 10, 2018 · 0 comments

Comments

@cartant
Copy link
Collaborator

cartant commented Jun 10, 2018 •
edited
Loading

Feature Request

To better test TypeScript expectations, we should be able to utilise Microsoft's dtslint tool.

I've had a look at how it could be integrated into the repo and I've created a branch that adds a dtslint script and adds the dtslint-related configuration and type-only tests to the type-specs directory:

cartant/rxjs/tree/dtslint/type-specs

The dtslint script can be added to the Travis $FULL_VALIDATE configuration.

This looks to me to be a great tool. Thoughts?

I was thinking that the type tests currently used in the test suite could be pretty easily be brought across to dtslint - in which the expectations would be more robustly tested.

Additional context
@benlesh benlesh added type: discussion AGENDA ITEM Flagged for discussion at core team meetings labels Jun 11, 2018
@cartant cartant mentioned this issue Jun 14, 2018
Closed
@cartant cartant mentioned this issue Jul 2, 2018
Closed
cartant added a commit to cartant/rxjs that referenced this issue Jul 23, 2018
@cartant
fix(pipe): replace rest parameters overload
96e2add 
Replace the rest parameters overload with a signature that also includes
the A-I type parameters.

Closes ReactiveX#3823 ReactiveX#3841
@cartant cartant mentioned this issue Jul 23, 2018
Merged
@benlesh benlesh removed the AGENDA ITEM Flagged for discussion at core team meetings label Aug 1, 2018
@cartant cartant closed this as completed Aug 14, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benlesh @cartant