Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipUntil() operator behavior #518

Closed
kwonoj opened this issue Oct 13, 2015 · 1 comment
Closed

skipUntil() operator behavior #518

kwonoj opened this issue Oct 13, 2015 · 1 comment
Assignees
Labels
bug Confirmed bug

Comments

@kwonoj
Copy link
Member

kwonoj commented Oct 13, 2015

Current implementation of skipUntil() does not handle some cases such as argument observable raises error like

var e1 =   hot('--a--b--c--d--e--|');
var skip = hot('-------------#');
var expected = '-------------#';

expectObservable(e1.skipUntil(skip)).toBe(expected);

Marble diagram of RxJS4 test expected to pass but fail.

@kwonoj
Copy link
Member Author

kwonoj commented Oct 13, 2015

I'll look into as well as expanding test coverage.

@benlesh benlesh added the bug Confirmed bug label Oct 13, 2015
kwonoj added a commit to kwonoj/rxjs that referenced this issue Oct 14, 2015
- update skipUntil operator behavior
- add test coverage

relates to ReactiveX#518
kwonoj added a commit to kwonoj/rxjs that referenced this issue Oct 14, 2015
- update skipUntil operator behavior
- add test coverage

closes ReactiveX#518
@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Confirmed bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants