Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retry and retryWhen don't call unsubscription logic when the source observable errors #546

Closed
benlesh opened this issue Oct 16, 2015 · 2 comments
Closed

retry and retryWhen don't call unsubscription logic when the source observable errors #546

benlesh opened this issue Oct 16, 2015 · 2 comments
Labels
bug Confirmed bug help wanted Issues we wouldn't mind assistance with.
Milestone
Initial Beta

Comments

@benlesh
Copy link
Member

benlesh commented Oct 16, 2015

Basically this scenario:

Observable.create(observer => {
  observer.error('bad');
  return () => {
    console.log('tear down');
  };
}).retryWhen(errors => Observable.timer(3000))

that "tear down" is never logged to console.
@benlesh benlesh added bug Confirmed bug help wanted Issues we wouldn't mind assistance with. labels Oct 16, 2015
@benlesh benlesh added this to the Initial Beta milestone Oct 16, 2015
@staltz
Copy link
Member

staltz commented Oct 16, 2015

I can do this

staltz pushed a commit to staltz/RxJSNext that referenced this issue Oct 16, 2015
fix(retry): fix internal unsubscriptions for retry
6468857 
Fix retry operator to unsubscribe from the source whenever the
source emits an error and a new retry will be attempted. Also fix the
operator to unsubscribe the internal retried subscription to the source
whenever the result Observable is unsubscribed.

Resolves issue ReactiveX#546.
@staltz staltz mentioned this issue Oct 16, 2015
Closed
benlesh pushed a commit that referenced this issue Oct 16, 2015
@benlesh
fix(retry): fix internal unsubscriptions for retry
cc92f45 
Fix retry operator to unsubscribe from the source whenever the
source emits an error and a new retry will be attempted. Also fix the
operator to unsubscribe the internal retried subscription to the source
whenever the result Observable is unsubscribed.

Resolves issue #546.
@benlesh benlesh mentioned this issue Oct 16, 2015
Closed
@staltz staltz mentioned this issue Oct 17, 2015
Closed
@staltz
Copy link
Member

staltz commented Oct 19, 2015

This can be now closed.

@benlesh benlesh closed this as completed Oct 20, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Confirmed bug help wanted Issues we wouldn't mind assistance with.
Projects
None yet
Milestone
Initial Beta
Development

No branches or pull requests
2 participants
@staltz @benlesh