Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(OuterSubscriber): notifyNext passes innersubscriber when next emits #1252

Closed
wants to merge 1 commit into from

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Jan 26, 2016

  • notifyNext() passes inner subscriber as same as notifyError(), notifyComplete() does, supports subscription management

closes #1250

Ran some perf against after applying changes, couldn't see noticeable differences.


before

------------------------------------------------------------------------------------------
            buffer - immediate |   33,135 (±5.19%) |   94,162 (±6.56%) |  2.84x |   184.2%
     combinelatest - immediate |   11,154 (±3.08%) |  118,908 (±3.02%) | 10.66x |   966.0%
                 combinelatest |    8,443 (±3.54%) |   81,640 (±3.08%) |  9.67x |   867.0%
          debounce - immediate |    5,874 (±8.76%) |   23,409 (±5.11%) |  3.98x |   298.5%
          mergemap - immediate |    2,450 (±2.71%) |   23,331 (±2.82%) |  9.52x |   852.4%
                      mergemap |      606 (±2.93%) |    4,912 (±3.66%) |  8.11x |   711.2%
         skipuntil - immediate |   22,688 (±2.62%) |  101,935 (±5.70%) |  4.49x |   349.3%
            switch - immediate |    2,920 (±2.64%) |   26,361 (±3.44%) |  9.03x |   802.9%
                        switch |    5,317 (±3.48%) |   25,154 (±3.42%) |  4.73x |   373.1%
         takeuntil - immediate |    3,689 (±2.56%) |  106,054 (±5.00%) |  4.48x |   347.7%
               zip - immediate |    2,554 (±3.67%) |   71,988 (±2.33%) |  5.73x |   473.4%
               zip - immediate |    5,742 (±3.35%) |   68,654 (±2.19%) | 11.96x | 1,095.6%

after
------------------------------------------------------------------------------------------
            buffer - immediate |   32,050 (±6.50%) |   97,139 (±6.60%) |  3.03x |   203.1%
     combinelatest - immediate |  11,156 (±11.48%) |  121,978 (±2.40%) | 10.93x |   993.3%
                 combinelatest |    9,201 (±2.95%) |   82,289 (±2.97%) |  8.94x |   794.3%
          debounce - immediate |    5,706 (±7.35%) |   27,265 (±3.34%) |  4.78x |   377.9%
          mergemap - immediate |    2,661 (±2.95%) |   24,345 (±3.02%) |  9.15x |   815.0%
                      mergemap |      668 (±3.00%) |    5,073 (±2.77%) |  7.60x |   659.6%
         skipuntil - immediate |   21,837 (±2.87%) |  101,634 (±6.39%) |  4.65x |   365.4%
            switch - immediate |    2,837 (±2.65%) |   27,601 (±3.18%) |  9.73x |   872.9%
                        switch |    6,096 (±2.82%) |   25,593 (±3.19%) |  4.20x |   319.8%
         takeuntil - immediate |   23,559 (±2.51%) |  105,616 (±5.15%) |  4.48x |   348.3%
               zip - immediate |   12,793 (±3.45%) |   70,808 (±2.84%) |  5.54x |   453.5%
               zip - immediate |    6,021 (±3.10%) |   68,313 (±2.38%) | 11.35x | 1,034.6%

- notifyNext() passes inner subscriber as same as notifyError(), notifyComplete() does, supports subscription management

closes ReactiveX#1250
@benlesh
Copy link
Member

benlesh commented Jan 27, 2016

LGTM.

@kwonoj
Copy link
Member Author

kwonoj commented Jan 27, 2016

Merged with 1df8928, thanks for reviewing @Blesh :)

@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OuterSubscriber::notifyNext() to pass its innersubscriber?
2 participants