fix(multicast): Fixes multicast with selector to create a new source connection per subscriber. #1774
Conversation
| const sourceSubs = ['^ !']; | ||
| const sourceSubs = ['^ !', | ||
| ' ^ !', | ||
| ' ^ !']; | ||
| const multicasted = source.multicast(() => new Subject(), | ||
| x => x.zip(x, (a, b) => (parseInt(a) + parseInt(b)).toString())); |
There was a problem hiding this comment.
In here, can we assert that x is something expected? Also, can we return something more clear? Maybe a simple map like: x.map(v => v + '!'). Then just use the values argument to expectObservable to assert.
There was a problem hiding this comment.
@Blesh the point of multicast with a selector is to allow multiple subscriptions to the multicast Observable inside the selector function, and one source connection per outer subscriber. By zipping x with itself, this test is guaranteeing two subscriptions to x for each connection to the multicast source.
I think this is a good test, but I'll add a test with a cold source as well to cover all cases.
|
Good catch @trxcllnt! Just one little thing in the test |
…connection per subscriber. Multicast with a selector function should create a new ConnectableObservable for each subscriber to the MulticastObservable. This ensures each subscriber creates a new connection to the source Observable, and don't share subscription side-effects.
trxcllnt
force-pushed
the
fix-multicast-observable
branch
from
4aa9041
to
ca361e4
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description:
Multicast with a selector function should create a new ConnectableObservable for each subscriber to
the MulticastObservable. This ensures each subscriber creates a new connection to the source
Observable, and don't share subscription side-effects.
Multicast with selector now matches Rx4's behavior.