Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Subject): allow type definition to next value optionally #1780

Merged
merged 1 commit into from
Jun 21, 2016

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Jun 20, 2016

Description:
This PR updates type definition to Subject::next to allow next value optionally.
This does not changes actual behavior, it was allowed to next() in JS already.

Related issue (if exists):

closes #1728

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.366% when pulling 3e0c6d9 on kwonoj:subject-optional into 97d43fe on ReactiveX:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.366% when pulling 3e0c6d9 on kwonoj:subject-optional into 97d43fe on ReactiveX:master.

@kwonoj kwonoj merged commit 57d64cb into ReactiveX:master Jun 21, 2016
@kwonoj kwonoj deleted the subject-optional branch June 21, 2016 05:32
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subject<void> and next() optional value
2 participants