Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pr 1977 #2018

Merged
merged 2 commits into from
Oct 10, 2016
Merged

Pr 1977 #2018

merged 2 commits into from
Oct 10, 2016

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Oct 10, 2016

rebased version of #1977

@dancasey @benlesh
docs(Observable): bindNodeCallback
fc00aa1 
Change doc to match source: bindNodeCallback's selector parameter is optional.
@dancasey @benlesh
docs(Observable): bindCallback
e309629 
Change doc to match source: bindCallback's selector parameter is optional.
@benlesh benlesh mentioned this pull request Oct 10, 2016
Closed
@benlesh benlesh merged commit 5e28e52 into ReactiveX:master Oct 10, 2016
@coveralls
Copy link

coveralls commented Oct 10, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 97.051% when pulling e309629 on blesh:pr-1977 into c7cfe44 on ReactiveX:master.

@benlesh benlesh deleted the pr-1977 branch December 16, 2016 03:09
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benlesh @coveralls @dancasey