Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(buffer): subscribe to source and closingNotifier in proper order #2195

Merged
merged 2 commits into from
Jun 14, 2017
Merged

fix(buffer): subscribe to source and closingNotifier in proper order #2195

merged 2 commits into from
Jun 14, 2017

Commits on Feb 15, 2017

  1. fix(buffer): subscribe to source and closingNotifier in proper order 

    In buffer operator subscribe to source observable first, so that when
closingNotifier emits value, all source values emited before land in buffer

Closes #1610
BREAKING CHANGE:
When source and closingNotifier fire at the same time, it is expected
that value emitted by source will first land in buffer and then
closingNotifier will close it. Because of reversed subscription order,
closingNotifier emitted first, so source was not able to put value in
buffer before it was closed. Now source is subscribed before closingNotifier,
so if they fire at the same time, source value is put into buffer and then
closingNotifer closes it.
    @mpodlasin
    mpodlasin committed Feb 15, 2017
    Configuration menu
    Copy the full SHA
    425aca5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'next' into buffer-subscription-order

    @jayphelps
    jayphelps authored Feb 15, 2017
    Configuration menu
    Copy the full SHA
    15d5ac9 View commit details
    Browse the repository at this point in the history