Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tutorial): Log target values and not the events #2230

Merged
merged 1 commit into from
Feb 21, 2017

Conversation

jtefera
Copy link
Contributor

@jtefera jtefera commented Dec 31, 2016

We want to log the input values and not the keypress events.

We want to log the input values and not the keypress events.
@coveralls
Copy link

coveralls commented Dec 31, 2016

Coverage Status

Coverage remained the same at 97.69% when pulling 0ab524e on jtefera:patch-1 into 6922b16 on ReactiveX:master.

@benlesh
Copy link
Member

benlesh commented Feb 21, 2017

LGTM, thanks @jtefera! ❤️

@benlesh benlesh merged commit 28dc78f into ReactiveX:master Feb 21, 2017
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants