Bringing our next branch up to date
#2317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
combineLatest lease enter the commit message for your changes. Lines starting
…if the catch subscription is di (#2271) This is a non-breaking change to make track and dispose its subscription to the Observable returned from the catch selector if the catch subscriber is disposed early.
When using a number interval, we must now use `sampleTime` instead of `sample`. This was not specified in the document.
* Change keyboard event in tutorial example The `keypress` event is send before the value has been set on the input element : it always returns the last value of the element. When 'keydown' is send, the value has already been set on the input; returning the actual value. * Update basics.md The KeyboardEvent (keydown, keypress, keyup) indicates just what's happening on a key. When you need to handle text input, use HTML5 input event instead. For example, if user inputs text from hand-writing system like tablet PC, key events may not be fired.
…Handler - relates to #1900
Align fromEventPattern behavior to RxJS v4
docs(count): fix typo
* chore(readme): Simplifes CDN usage directions * chore(cdn): use rxjs package not reactivex/rxjs
* docs(operators): mergeScan * docs(operators): toPromise * docs(toPromise): Fix copy-paste mistake * docs(mergeScan): `var` -> `const`. Use Finnish notation.
docs(operators): examples for catch operator
refactor(windowTime): clarify type definition of windowTime
* test(AsyncSubject): asyncsubject should not send complete event after error * fix(AsynSubject): check if there is an error first * test(AsyncSubject): asyncSubject should not send error event after complete * fix(AsyncSubject): only pass error if asyncsubject is not completed
…o match native Array reduce behavior - closes #2290
…e` and `ColdObservable` instead of Observable (#2305) Return `HotObservable` and `ColdObservable` instead of simply `Observable`, in order to give users access to subscriptions parameter
…servable's initializer function is the same. - closes #2166
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.