Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(all): enable type inference to marble diagram #2346

Merged
merged 1 commit into from
Feb 9, 2017

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Feb 9, 2017

Description:
This PR is following changes from #2202 apply enabling type inferences for marble test method.

Related issue (if exists):

@rxjs-bot
Copy link

rxjs-bot commented Feb 9, 2017

Warnings
⚠️ ❗ Big PR (1)

(1) : Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

Generated by 🚫 dangerJS

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.689% when pulling 3b14f7d on kwonoj:chore-enable-type-test into 6ce4773 on ReactiveX:master.

@kwonoj kwonoj requested a review from jayphelps February 9, 2017 05:47
@kwonoj
Copy link
Member Author

kwonoj commented Feb 9, 2017

@jayphelps I just went ahead and enable most of test cases's type inference to prevent further PR blocked by our github bot 🤖 . Since this is trivial change, I've cc'ed you for review but will check in myself around tomorrow.

@coveralls
Copy link

coveralls commented Feb 9, 2017

Coverage Status

Coverage remained the same at 97.689% when pulling 3b14f7d on kwonoj:chore-enable-type-test into 6ce4773 on ReactiveX:master.

@jayphelps jayphelps merged commit 31dfc73 into ReactiveX:master Feb 9, 2017
@kwonoj kwonoj deleted the chore-enable-type-test branch February 9, 2017 19:06
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants