docs(create): add more details about static create function #2390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flesh out what is an Observable Contract. Add note about returning TeardownLogic in passed function. Change 'subscribe' to 'onSubscription' so that there is no confusion when function is called. Switch Subscriber instance as a function argument to Observer interface, so that users are not encouraged to use Subscribers implementation details. Add note about TS signature issue. Add examples with calling observers error and returning teardown logic. Do not mark function passed to create as optional, since subscribing to Observable created in such way will throw an Error.
benlesh
approved these changes
Feb 21, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Observable Contract.TeardownLogicin passed function.subscribetoonSubscriptionso that there is no confusion when function is called.Subscriberinstance as a function argument toObserverinterface, so that users are not encouraged to use Subscribers implementation details.