fix(zipAll): complete when the source is empty #2451
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the situation where the
zipAll()
operator doesn't sendcomplete
notification when the source Observable is empty:This doesn't print anything. Demo: https://jsbin.com/fucijuz/2/edit?js,console
Description:
This problem occurs only when using
zipAll()
and notzip()
. Thezip()
operator internally wrapszipAll()
withArrayObservable
. So the following works fine:This is internally called as:
which is all right.
Related issue (if exists):
#2426