fix(subscribeToResult): throw error in subscriber with inner observable

[kwonoj]

Description:
#2626 fixed error to be thrown when observable have sources, but it doesn't cover cases of inner observable with subscribeToResult as it doesn't have sources. This PR explicitly sets subscriber's syncErrorThrowable for inner observables, let exception in subscribers correctly thrown with inner observables as well.

Related issue (if exists):

• closes subscribe onError swallows any exception thrown #2618

[kwonoj]

I believe this is patch as it fixes regressions.

[rxjs-bot]

	Messages
📖

CJS: 3175.9KB, global: 589.0KB (gzipped: 108.6KB), min: 138.0KB (gzipped: 29.1KB)

Generated by 🚫 dangerJS

[coveralls]

Coverage increased (+0.0003%) to 97.736% when pulling d7bffa9 on kwonoj:fix-shallow-error into 74ff463 on ReactiveX:master.

[jayphelps]

Do you have cycles to add a test case? Dunno if this is truly minimum but it reproduces it:

const input$ = new Rx.Subject();

input$
  .mergeMap(() => Rx.Observable.of(1, 2))
  .subscribe(d => {
    throw new Error('some error');
  });

input$.next();

[kwonoj]

@jayphelps I've used given snippet to verify behavior. Have to think a bit for test cases.

[kwonoj]

@jayphelps test case updated.

[coveralls]

Coverage increased (+0.0003%) to 97.736% when pulling 731be99 on kwonoj:fix-shallow-error into 74ff463 on ReactiveX:master.

[coveralls]

Coverage increased (+0.0003%) to 97.736% when pulling c935bf5 on kwonoj:fix-shallow-error into 74ff463 on ReactiveX:master.

[coveralls]

Coverage increased (+0.0003%) to 97.736% when pulling c935bf5 on kwonoj:fix-shallow-error into 74ff463 on ReactiveX:master.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.