Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(global): export lettables as Rx.operators #2862

Merged
merged 1 commit into from
Sep 26, 2017
Merged

feat(global): export lettables as Rx.operators #2862

merged 1 commit into from
Sep 26, 2017

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Sep 25, 2017

fixes #2861

Description:

Related issue (if exists):

@rxjs-bot
Copy link

Messages
📖

CJS: 1342.6KB, global: 739.6KB (gzipped: 138.7KB), min: 146.0KB (gzipped: 31.2KB)

Generated by 🚫 dangerJS

@benlesh
Copy link
Member Author

benlesh commented Sep 26, 2017

This does add a lot of size to the global bundle, but the global bundle is really meant for playground code and/or code being used in node.js or the like.

@benlesh benlesh merged commit ba2f586 into ReactiveX:master Sep 26, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling 6aeae0f on benlesh:export_lettables into 2e576dc on ReactiveX:master.

@lock
Copy link

lock bot commented Jun 5, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lettable operators are not exposed in global bundle.
4 participants