Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shareReplay): again uses lift #2924

Merged
merged 1 commit into from
Oct 9, 2017
Merged

fix(shareReplay): again uses lift #2924

merged 1 commit into from
Oct 9, 2017

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Oct 9, 2017

  • adds a test to ensure lift it being used.
  • uses lift.

NOTE: this is a first attempt also at using lift in a non-class-based (but also non-breaking) way.

@rxjs-bot
Copy link

rxjs-bot commented Oct 9, 2017

Messages
📖

CJS: 1346.3KB, global: 745.4KB (gzipped: 139.9KB), min: 145.4KB (gzipped: 30.8KB)

Generated by 🚫 dangerJS

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 97.412% when pulling 1bfb558 on benlesh:shareReplay_lift into 4dc73e4 on ReactiveX:master.

1 similar comment
@coveralls
Copy link

coveralls commented Oct 9, 2017

Coverage Status

Coverage decreased (-0.06%) to 97.412% when pulling 1bfb558 on benlesh:shareReplay_lift into 4dc73e4 on ReactiveX:master.

return (source: Observable<T>) => source.lift(shareReplayOperator(bufferSize, windowTime, scheduler));
}

export function shareReplayOperator<T>(bufferSize?: number, windowTime?: number, scheduler?: IScheduler) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need export this function.

@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants