chore(typings): improve publish typings #2983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use ConnectableObservable in signatures that do not have selectors.
Generated by 🚫 dangerJS |
-+12.4KB-red.svg?style=flat-square){kind=icon}
-+2.5KB-red.svg?style=flat-square){kind=icon}
cartant
force-pushed
the
publish-typings
branch
from
6c0587e
to
34b3407
Compare
benlesh
approved these changes
Oct 25, 2017
|
Tested this and I seems to work fine in TS 2.5. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
ConnectableObservablein signatures that do not have selectors.Description:
This PR updates the overload signatures for lettable/pipeable
publish,publishLastandmulticastoperators so thatConnectableObservableis specified where appropriate.I've not includedtypetests, as it's not apparent where they should be placed. That is, the lettable operators appear to be tested via the prototype-patched operators inspec/operators. If you'd like the typings tests for the lettables added in the same location, please let me know and I'll add them.The PR does not completely resolve the issue below, but it is directly related to it. And these changes would need to be made as the first step in resolving the issue.
Related issue (if exists): #2972