Merge refactor #316
Merged
Merge refactor #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- moves support types from merge-support to mergeAll-support - fixes strange issues with async - adds virtual time tests for merge and mergeAll
…efore hot subjects
- adds virtual time tests for expand - refactors expand to be its own operator, reducing inheritence
- removes inheritance from merge - improves performance through fewer function calls - ensures scalar (same behavior as before, but readded)
- still inherits from flatMap, but flatMap has changed slightly
makes ability to schedule more apparent
- make ability to schedule more apparent - check for scheduler and insert concurrency of 1 at proper point for merge call
|
Oh, one additional thing...
|
…se subscriber instead
| constructor(destination: Observer<T>, | ||
| project: (value: T, index: number) => Observable<R>, | ||
| resultSelector?: (innerValue: R, outerValue: T, innerIndex: number, outerIndex: number) => R2) { | ||
| super(destination, project, resultSelector, 1); |
There was a problem hiding this comment.
@Blesh Does this work? It looks like this makes the SwitchLatestSubscriber equivalent to concat... right?
This was referenced Sep 16, 2015
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to problems outlined in #302, I ended up adding more virtual time tests and found quite some behaviors weren't working as expected. Since #222 is still open, and it's something I wanted to tackle, and since the high level of inheritance in operators like
switchAllmade debugging a little painful, I opted for a refactor.Unfortunately, refactoring merge touched a lot of other operators (
concat,concatAll,switchAll,switchLatest,switchLatestTo,flatMap,flatMapTo,merge,mergeAll,Observable.merge,Observable.concat, andexpand)The basics of the changes are as follows:
expandhas it's own standalone subscriberflatMaphas it's own standalone subscriberswitchAllhas it's own standalone subscribermergeAllhas it's own standalone subscriberswitchLatest(which should beswitchMap) inherits fromflatMapsubscriberflatMapToinherits fromflatMapsubscriberswitchLatestToinherits fromflatMapTosubscriberother changes were just changes to calls to reflect better typing information.
Also, I had to fix a bug in the TestScheduler that was having
hotobservables subscribe and emit before the expectation observables did. This meant that if a subject (hot observable) emitted on frame 0, it wouldn't be provided to the expectation observable being tested because it hadn't subscribed yet.sincerest apologies for such a large PR
... at least I broke it into several commits.