fix(forkJoin): fix forkJoin typings for forkJoin(Observable<any>[]) #3436
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwonoj
reviewed
Mar 15, 2018
src/internal/observable/forkJoin.ts
Outdated
| export function forkJoin<T>(sources: Array<ObservableInput<T>>): Observable<T[]>; | ||
| export function forkJoin<T>(...sources: Array<ObservableInput<T>>): Observable<T[]>; | ||
| export function forkJoin<T>(v1: ObservableInput<T>): Observable<T[]>; |
There was a problem hiding this comment.
not exactly sure, but prolly this could be go line 10 instead?
benlesh
force-pushed
the
forkJoin-shennanigans
branch
from
3a269bd
to
439a109
Compare
benlesh
force-pushed
the
forkJoin-shennanigans
branch
from
439a109
to
ff8fd44
Compare
|
It now also updates typings to be a little nicer for people passing an array in. |
kwonoj
approved these changes
Mar 15, 2018
This was referenced Mar 19, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves an issue where we were hitting the wrong typings for forkJoin if passed an Array of observables.