Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancellable forEach #3977

Merged
merged 6 commits into from
Aug 3, 2018
Merged

Cancellable forEach #3977

merged 6 commits into from
Aug 3, 2018

Commits on Jul 30, 2018

  1. feat(forEach): now allows cancellation by passing a Subscription

    @benlesh
    benlesh committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    8b74c2a View commit details
    Browse the repository at this point in the history

  2. feat(forEach): deprecating passing promise constructor 

    - Adds documentation
- Deprecates promise constructor
    @benlesh
    benlesh committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    5178ab9 View commit details
    Browse the repository at this point in the history

  3. fixup! feat(forEach): deprecating passing promise constructor

    @benlesh
    benlesh committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    3437239 View commit details
    Browse the repository at this point in the history

  4. fixup! feat(forEach): now allows cancellation by passing a Subscription

    @benlesh
    benlesh committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    cb6dd81 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2018

  1. fix(Observable): forEach will no longer next values after an error

    @benlesh
    benlesh committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    b4bad1f View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2018

  1. refactor(forEach): rejects with ObjectUnsubscribedError if cancelled … 

    …by passed Subscription
    @benlesh
    benlesh committed Aug 2, 2018
    Configuration menu
    Copy the full SHA
    4707a92 View commit details
    Browse the repository at this point in the history