Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(WebSocketSubject): fix subject failing to close socket #4446

Merged
merged 1 commit into from
Jan 29, 2019
Merged

fix(WebSocketSubject): fix subject failing to close socket #4446

merged 1 commit into from
Jan 29, 2019

Commits on Jan 2, 2019

  1. fix(WebSocketSubject): fix subject failing to close socket 

    Fix WebSocketSubject failing to close the underlying socket connection when it is unsubscribed
before the socket is in the open state. Currently, when unsubscribe is called on the subject or
when a subscription is unsubscribed there are checks on whether the socket is open (readyState = 1)
before it closes the connection. If unsubscribe is called before the connection is open, it will not
close the socket but will reset the state of the subject (_socket set to null), and it becomes
impossible to close the socket.
    @rsikdar
    rsikdar committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    85e7f3a View commit details
    Browse the repository at this point in the history