Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(angular): migrate app from angular 6 to 8(#4687) #4688

Merged
merged 9 commits into from
Aug 27, 2019
Merged

docs(angular): migrate app from angular 6 to 8(#4687) #4688

merged 9 commits into from
Aug 27, 2019

Conversation

Daschyppoo
Copy link
Contributor

Description: Migrate the angular version from 6.1.0 to 7.2.12. Also fixed an minor Issue with the Operator Decision Tree after migrating. In Addition codelyzer, typescript and eslint were updated after migration to angular 7.

Related 4687:

@rxjs-bot
Copy link

rxjs-bot commented Apr 4, 2019

Warnings
⚠️

❗ Big PR (1)
⚠️

commit message does not follows conventional change log (2)

(1) : Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

(2) : RxJS uses conventional change log to generate changelog automatically. It seems some of commit messages are not following those, please check contributing guideline and update commit messages.

Generated by 🚫 dangerJS

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8317

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.871%
Totals Coverage Status
Change from base Build 8316: 0.0%
Covered Lines: 5789
Relevant Lines: 5976
💛 - Coveralls

@niklas-wortmann
Copy link
Member

niklas-wortmann commented May 1, 2019 •
edited
Loading

Tests are broken in the docs app now. You can run them with npm run test inside the docs_app folder.
If you need help with that, just let me know! Thanks a lot for this contribution!

@BioPhoton BioPhoton mentioned this pull request Jun 8, 2019
Closed
5 tasks
@niklas-wortmann
Copy link
Member

I will support with this PR and also use it for the migration to angular 8 to just fix the tests once :D

@niklas-wortmann niklas-wortmann changed the title docs(angular): migrate app from angular 6 to 7(#4687) docs(angular): migrate app from angular 6 to 8(#4687) Jun 14, 2019
@sumitarora
Copy link

@jwo719 Did the manual testing for the docs on local everything seems to be working fine. I also didn't get any setup issues mentioned above. LGTM to 🚢 😄

@kanafghan
Copy link

I also did manual testing of the docs locally and could not find anything noticeable.

@niklas-wortmann niklas-wortmann mentioned this pull request Jul 10, 2019
Merged
@cmwhited
Copy link

@jwo719 can I get a status update on this PR so that we can get it merged and then get #4872 merged as well?

@niklas-wortmann
Copy link
Member

I'll need to fix the minor issues mentioned above. Will do it this evening!

@cmwhited
Copy link

Awesome! Thank you very much @jwo719

niklas-wortmann
niklas-wortmann reviewed Jul 18, 2019
View reviewed changes
Copy link
Member

@niklas-wortmann niklas-wortmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed all the comments!

@benlesh
Copy link
Member

benlesh commented Aug 1, 2019

@jwo719 are we going to be able to update this in both master and 6.x? 😬

@niklas-wortmann niklas-wortmann added the AGENDA ITEM Flagged for discussion at core team meetings label Aug 13, 2019
@BioPhoton BioPhoton mentioned this pull request Aug 19, 2019
Closed
@benlesh benlesh removed AGENDA ITEM Flagged for discussion at core team meetings PR: needs review labels Aug 27, 2019
@benlesh benlesh merged commit e64dc99 into ReactiveX:master Aug 27, 2019
niklas-wortmann pushed a commit that referenced this pull request Aug 27, 2019
@Daschyppoo
docs(angular): migrate app from angular 6 to 8(#4687) (#4688)
3881723 
* docs(operator): add missing marble diagramms

* Revert "docs(operator): add marbel diagramm to distinctUntilChanged"

This reverts commit 6bf3aae.

* Revert "docs(operator): add fitting description and diagramm to distinctUntilKeyChanged"

This reverts commit 98c23b5.

* Revert "docs(operator): add missing marble diagramms"

This reverts commit b61acad.

* docs(angular): update angular/ codelyzer/ typescript version

* docs(angular): fix minor errors after migration

* chore(eslint): update version

* docs(app): upgrade to angular 8

* docs(migration): fix wrong polyfill imports
@niklas-wortmann niklas-wortmann mentioned this pull request Aug 27, 2019
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kanafghan kanafghan kanafghan left review comments

@niklas-wortmann niklas-wortmann niklas-wortmann left review comments

@benlesh benlesh benlesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Daschyppoo @rxjs-bot @coveralls @niklas-wortmann @sumitarora @kanafghan @cmwhited @benlesh