Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(throttleTime): double emission with leading and trailing enabled #4727

Closed
wants to merge 3 commits into from
Closed

fix(throttleTime): double emission with leading and trailing enabled #4727

wants to merge 3 commits into from

Commits on Jul 24, 2019

  1. test(throttleTime): test leading and trailing enabled 

    Test for double emission with leading and trailing enabled.
Also add more tests for leading and trailing enabled.

Double emission problem:
source:   a123b12-c-23d-2-ef---
expected: a---b---c---d---e---f
actual:   a---b1---c2---2-e---f
    @MatthiasKunnen
    MatthiasKunnen committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    90f7013 View commit details
    Browse the repository at this point in the history

  2. fix(throttleTime): fix double emission with leading and trailing enabled 

    Fix an issue with throttleTime emitting both leading and trailing values in the same time window.

Double emission problem:
source:   a123b12-c-23d-2-ef---
expected: a---b---c---d---e---f
actual:   a---b1---c2---2-e---f

Closes ReactiveX#2466 and ReactiveX#2727.
Follows ReactiveX#2749 and ReactiveX#2864.

BREAKING CHANGE: throttleTime no longer emits both leading and trailing
values in the same time window.
    @MatthiasKunnen
    MatthiasKunnen committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    bd2d6b1 View commit details
    Browse the repository at this point in the history

  3. fix(throttleTime): throttle before next 

    It was pointed out that the timings could be influenced due to slow user code, this has now been
solved.
    @MatthiasKunnen
    MatthiasKunnen committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    1a3fe43 View commit details
    Browse the repository at this point in the history