fix(TS): fix type inference for publish variants #4816
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
benlesh
commented
May 29, 2019
benlesh
commented
- We can never get out of via TypeScript any how.
- Resolves a larger issue where operators with a single, static argument and a single generic inferred too strongly from the argument and lost the additional type information from the source.
|
I would really like to revisit the changes you proposed in #3833. If not for v7 then for v8. |
benlesh
force-pushed
the
fix_publish_typings
branch
from
576bd28
to
1a5c538
Compare
|
I'm rebasing this. For some reason there's a build failure in CI that I haven't been able to reproduce locally |
benlesh
force-pushed
the
fix_publish_typings
branch
from
1a5c538
to
4d58596
Compare
- We can never get out of via TypeScript any how. - Resolves a larger issue where operators with a single, static argument and a single generic inferred too strongly from the argument and lost the additional type information from the source.
benlesh
force-pushed
the
fix_publish_typings
branch
from
4d58596
to
5753dab
Compare
|
This has already been handled. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.