chore: use strict TS option for dtslint #5045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwonoj
approved these changes
Sep 28, 2019
|
@benlesh It would be nice to get this merged, too. |
cartant
force-pushed
the
strict-dtslint
branch
from
5807df5
to
15cb2db
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As mentioned in #4968, the TypeScript compiler options could be more strict. Changing this is going to involve code changes. However, there's no reason we cannot enable
strictfor the dtslint tests right now. Doing so will allow us to use$ExpectErrorin more situations in our dtslint tests - the'strictNullChecks': falsein the current configuration will prevent some types of errors from being reported.Related issue (if exists): #4968