Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix take and takeLast #5326

Merged
merged 3 commits into from
May 14, 2020
Merged

Fix take and takeLast #5326

merged 3 commits into from
May 14, 2020

Commits on Apr 2, 2020

  1. fix(take): add runtime argument checks 

    BREAKING CHANGE: take will not throw runtime error for arguments that are negative or NaN, this includes non-TS calls like `take()`.
    @benlesh
    benlesh committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    370e231 View commit details
    Browse the repository at this point in the history

  2. chore: update takeLast tests

    @benlesh
    benlesh committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    7ab8876 View commit details
    Browse the repository at this point in the history

  3. fix(takeLast): add runtime assertions for invalid arguments 

    BREAKING CHANGE: Calling takeLast without arguments or with an argument that is NaN will throw a TypeError
    @benlesh
    benlesh committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    9af710d View commit details
    Browse the repository at this point in the history