Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ajax): implement url params inside ajax body #5384

Closed
wants to merge 2 commits into from

Conversation

OmarioHassan
Copy link

implement url query params to make it easy for user to pass it dynamically as an object and not to make it by himself and joining it with the url

implement url query params to make it easy for user to pass it dynamically as an object and not to make it by himself and joining it with the url
fix url const  against to be undefuned
@OmarioHassan
Copy link
Author

@benlesh I think about this change it's a good change because i use Ajax alwayes with qParams more than HttpClient in Angular.
Did you see that it missed something ?

@benlesh benlesh added the AGENDA ITEM Flagged for discussion at core team meetings label Jul 8, 2020
@benlesh benlesh removed the AGENDA ITEM Flagged for discussion at core team meetings label Aug 12, 2020
@benlesh
Copy link
Member

benlesh commented Aug 12, 2020

We've decided to hold off on adding this feature for now. We'll wait to see if it's requested in issues as time goes on.

@OmarioHassan
Copy link
Author

No problem
thanks for reply and your good efforts

@benlesh
Copy link
Member

benlesh commented Mar 24, 2021

I'm still not totally sure we're going to add this feature, but I've added a new PR at #6174, and I'm closing this one in favor of that one. They're both similar but there's a few things that are different about the updated PR.

One thing is that this tries to use new URL, which breaks if the user passes a relative url like /this. The other difference is that the new PR is more permissive with what it allows the user to pass as param, including URLSearchParams, a dictionary, an array of tuples, or a query string directly.

Thank you so much again for your hard work. If we land the new feature hopefully you find it useful.

@benlesh benlesh closed this Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants