Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

null out _unsubscribe after unsubscription #5465

Merged
merged 7 commits into from
Jul 30, 2020
Merged

null out _unsubscribe after unsubscription #5465

merged 7 commits into from
Jul 30, 2020

Commits on Jul 26, 2020

  1. null out _unsubscribe after unsubscription 

    Fixes ReactiveX#5464
    @felixfbecker @cartant
    felixfbecker authored and cartant committed Jul 26, 2020
    Configuration menu
    Copy the full SHA
    d92c97b View commit details
    Browse the repository at this point in the history

  2. test: add idempotent unsubscribe tests

    @cartant
    cartant committed Jul 26, 2020
    Configuration menu
    Copy the full SHA
    4022017 View commit details
    Browse the repository at this point in the history

  3. fix: null the subscription ctor teardown

    @cartant
    cartant committed Jul 26, 2020
    Configuration menu
    Copy the full SHA
    a07b74f View commit details
    Browse the repository at this point in the history

  4. refactor: use delete to remove the member

    @cartant
    cartant committed Jul 26, 2020
    Configuration menu
    Copy the full SHA
    34a513b View commit details
    Browse the repository at this point in the history

  5. refactor: delete _unsubscribe only if it exists

    @cartant
    cartant committed Jul 26, 2020
    Configuration menu
    Copy the full SHA
    125a410 View commit details
    Browse the repository at this point in the history

  6. refactor: replace delete with hasOwnProperty etc

    @cartant
    cartant committed Jul 26, 2020
    Configuration menu
    Copy the full SHA
    6b61b38 View commit details
    Browse the repository at this point in the history

  7. refactor: use _ctorUnsubscribe flag

    @cartant
    cartant committed Jul 26, 2020
    Configuration menu
    Copy the full SHA
    3ef0e1f View commit details
    Browse the repository at this point in the history