Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/5739 smaller operator creation #5742

Merged
merged 12 commits into from
Sep 23, 2020
Merged

Issue/5739 smaller operator creation #5742

merged 12 commits into from
Sep 23, 2020

Commits on Sep 23, 2020

  1. refactor: Create new operate internal operator creation function 

    resolves ReactiveX#5739
    @benlesh
    benlesh committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    3f87e7d View commit details
    Browse the repository at this point in the history

  2. fix(multicast): and other publish variants will handle errors thrown … 

    …in a selector appropriately

- Also refactors multicast to use the new `operate` mechanism.
    @benlesh
    benlesh committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    a780e97 View commit details
    Browse the repository at this point in the history

  3. refactor: remove last uses of wrappedLift

    @benlesh
    benlesh committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    258a3a2 View commit details
    Browse the repository at this point in the history

  4. refactor: remove unused lift and wrappedLift functions.

    @benlesh
    benlesh committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    34662e0 View commit details
    Browse the repository at this point in the history

  5. refactor(onErrorResumeNext): use OperatorSubscriber, don't return sub… 

    …scription in operate.
    @benlesh
    benlesh committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    7b6b239 View commit details
    Browse the repository at this point in the history

  6. refactor(repeat): Use OperatorSubscriber, don't return subscription… 

    … in `operate`
    @benlesh
    benlesh committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    608a159 View commit details
    Browse the repository at this point in the history

  7. refactor(retry): Use OperatorSubscriber, don't return subscription … 

    …in `operate`.
    @benlesh
    benlesh committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    ea0179a View commit details
    Browse the repository at this point in the history

  8. refactor: Don't return subscriber or subscription in operate unnece… 

    …ssarily.
    @benlesh
    benlesh committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    d85f67f View commit details
    Browse the repository at this point in the history

  9. refactor: use optional chaining

    @benlesh
    benlesh committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    c056a40 View commit details
    Browse the repository at this point in the history

  10. refactor(operate): Tweak init return type so Subscribers and Subscrip… 

    …tions can no longer be returned

This will help force us to make sure we are using the subscriber and subscription chaining in the most efficient way possible. Although it could result in anti-patterns where users return a function that calls unsubscribe on a subscription if we release this to the public.
    @benlesh
    benlesh committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    ee7de5d View commit details
    Browse the repository at this point in the history

  11. refactor(bufferToggle): rename liftedSource to source.

    @benlesh
    benlesh committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    7c694b6 View commit details
    Browse the repository at this point in the history

  12. chore: fix lint

    @benlesh
    benlesh committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    adac67b View commit details
    Browse the repository at this point in the history