Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/3990 buffer emit remainder on complete #6042

Merged

Commits on Feb 23, 2021

  1. test: add buffer/window equivalence tests

    cartant authored and benlesh committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    4c30f7d View commit details
    Browse the repository at this point in the history
  2. fix(buffer): closingNotifier completion does not complete resulting o…

    …bservable
    
    Resolves an issue where the resulting observable would complete when the closingNotifier completed. Notifier completion should not complete the result, only source completion should do that.
    
    BREAKING CHANGE: closingNotifier no longer closes the result of `buffer`. If that is truly a desired behavior, then you should use `takeUntil`. Something like: `source$.pipe(buffer(notifier$), takeUntil(notifier$.pipe(ignoreElements(), endWith(true))))`, where `notifier$` is multicast, although there are many ways to compose this behavior.
    benlesh committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    5a948a7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a83a9f0 View commit details
    Browse the repository at this point in the history
  4. fix(buffer): Remaining buffer will correctly be emited on source close.

    BREAKING CHANGE: Final buffered values will now always be emitted. To get the same behavior as the previous release, you can use `endWith` and `skipLast(1)`, like so: `source$.pipe(buffer(notifier$.pipe(endWith(true))), skipLast(1))`
    
    Fixes ReactiveX#3990, ReactiveX#6035
    benlesh committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    9ab9357 View commit details
    Browse the repository at this point in the history
  5. fix(window): final window stays open until source complete

    Resolves an issue where the windowBoundary complete would complete the resulting observable.
    
    BREAKING CHANGE: The windowBoundaries observable no longer completes the result. It was only ever meant to notify of the window boundary. To get the same behavior as the old behavior, you would need to add an `endWith` and a `skipLast(1)` like so:  `source$.pipe(window(notifier$.pipe(endWith(true))), skipLast(1))`.
    benlesh committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    0b07c86 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. Configuration menu
    Copy the full SHA
    b0109b0 View commit details
    Browse the repository at this point in the history