fix: catch within innerSubscribe #6186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartant
force-pushed
the
cartant/inner-subscribe-catch
branch
from
127c9a8
to
eea6559
Compare
benlesh
approved these changes
Mar 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this PR targets the
6.xbranch.Description:
AFAICT,
innerSubscribeis pretty much always called outside of atry/catchand that means that the error thatsubscribeTothrows if it receives an invalidObservableInputwon't be reported via the chained subscribers. Given thatinnerSubscribeis an internal v6 implementation detail and that's its always passed a known-to-be-safeSubscriber, it seems that any error effected could be reported directly to saidSubscriber.With this change, the bug reported in #5344 - which occurs only in v6 - is fixed.
Related issue (if exists): #5344