Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for anonymous observer issues #724

Closed
wants to merge 0 commits into from
Closed

Fix for anonymous observer issues #724

wants to merge 0 commits into from

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Nov 13, 2015

This is to address #723

  • minor (automatic) lint fix.
  • Adds tests for partially formed anonymous observers.
  • Updates the Observer interface to allow for optional handler registration.
  • Adds checks to ensure destination has a handler before calling the handler in Subscriber.

@kwonoj
Copy link
Member

kwonoj commented Nov 13, 2015

👍 Change looks fine for me.

@staltz
Copy link
Member

staltz commented Nov 15, 2015

👍

1 similar comment
@luisgabriel
Copy link
Contributor

👍

@benlesh benlesh closed this Nov 18, 2015
@benlesh benlesh mentioned this pull request Nov 30, 2015
Closed
@benlesh benlesh deleted the anonymous-observer branch November 30, 2015 23:08
@benlesh benlesh mentioned this pull request Dec 1, 2015
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benlesh @kwonoj @staltz @luisgabriel