Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider splicing the model out of the repo and PyPI release #130

Open
joanise opened this issue Nov 14, 2022 · 3 comments
Open

Consider splicing the model out of the repo and PyPI release #130

joanise opened this issue Nov 14, 2022 · 3 comments

Comments

@joanise
Copy link
Member

joanise commented Nov 14, 2022

The last release was a 50mb bundle because it now includes the cmusphinx model as part of the release.

This is OK, but we cannot let the bundle get much bigger, especially since PyPI has a size limit of 60mb by default.

See https://www.dampfkraft.com/code/distributing-large-files-with-pypi.html for a potential solution, like having the model as a downloadable file on the GitHub release instead of inside the PyPI bundle.

@joanise
Copy link
Member Author

joanise commented Nov 14, 2022

But this is not urgent: we're under the limit and things work as they are for now.

@dhdaines
Copy link
Collaborator

dhdaines commented Nov 14, 2022 via email

@joanise
Copy link
Member Author

joanise commented Nov 14, 2022

Ah, well, that might make the need to splice moot, then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants