Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around missing/broken editdistance package on python 3.12 #201

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

dhdaines
Copy link
Collaborator

@dhdaines dhdaines commented Feb 1, 2024

Fixes #200

@dhdaines dhdaines requested a review from joanise February 1, 2024 02:30
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9132b26) 87.04% compared to head (81effb9) 87.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #201   +/-   ##
=======================================
  Coverage   87.04%   87.04%           
=======================================
  Files          21       21           
  Lines        1744     1744           
  Branches      315      315           
=======================================
  Hits         1518     1518           
  Misses        189      189           
  Partials       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 1, 2024

CLI load time: 0:00.36
Pull Request HEAD: 81effb950f4717f9fe19d1da0d61a64463b323bb
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:    239719 |     300609 | pkg_resources

@joanise
Copy link
Member

joanise commented Feb 1, 2024

Darn, if this breaks our ability to push to pypi, it won't do. Let's give the editdistance owner a change to patch since you posted an issue, although to be honest I'm not hopeful given they haven't touched the repo in two years...

@joanise
Copy link
Member

joanise commented Feb 2, 2024

Maybe we could merge this in for now, and make a note that we have to revert it when we publish the next release? That would let us support Python 3.12 in the meantime, and hopefully we can find a better solution eventually.
I'm going to approve this PR on that premise, and make an issue.

@joanise joanise merged commit 81effb9 into main Feb 2, 2024
6 checks passed
@joanise joanise deleted the dev.editdistance-from-git branch February 2, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't install on Python 3.12, Ubuntu 22.04 due to broken editdistance package
3 participants