Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add a PR template #218

Merged
merged 1 commit into from
Apr 30, 2024
Merged

docs: add a PR template #218

merged 1 commit into from
Apr 30, 2024

Conversation

joanise
Copy link
Member

@joanise joanise commented Apr 29, 2024

PR Goal?

To add a standard template guiding PR submitters to provide better comments for reviewers.

Fixes?

n/a

Feedback sought?

If you're happy with the template, which I'm using here.

Priority?

low

Tests added?

n/a

How to test?

You can try it out with this link: https://github.com/joanise/just-testing/compare/main...dev.gzip-on-ci-all-OSs?expand=1&template=studio_web_pr_template.md

Confidence?

The template works fine in EveryVoice already, so I assume it'll be good here.

Version change?

no

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.17%. Comparing base (2eceb2a) to head (8559b39).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #218   +/-   ##
=======================================
  Coverage   87.17%   87.17%           
=======================================
  Files          21       21           
  Lines        1762     1762           
  Branches      321      321           
=======================================
  Hits         1536     1536           
  Misses        189      189           
  Partials       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

CLI load time: 0:00.05
Pull Request HEAD: 8559b39afc2c372f7d376dd70fb26b05cd8920d0
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package

Copy link
Collaborator

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@joanise joanise merged commit f57569e into main Apr 30, 2024
6 checks passed
@joanise joanise deleted the dev.ej/pr-template branch April 30, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants