Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring the bundled web-component up to date #220

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Conversation

joanise
Copy link
Member

@joanise joanise commented May 24, 2024

PR Goal?

update the long stale web-component offline bundles, and current web-component version.

Fixes?

Fixes #219

Feedback sought?

just make sure it works OK

Priority?

normal

Tests added?

n/a

How to test?

run cd test; readalongs align -o html data/ej-fra.txt data/ej-fra.m4a -l fra delme and see that the single-file HTML in delme has the gear menu (i.e., the latest web-component version) and index.html asks for [email protected].

Confidence?

high

Version change?

We're long overdue for a release, not for this PR but for previous changes, with at least a minor bump.

Significant changes:

  • we dropped Python 3.7 and added support for 3.12
  • we added the readme in the generated directory
  • Most changes were really in the web-component, not here.

Even though dropping Python 3.7 is a breaking change, I'd be inclined to just bump this project to 1.1, not 2.0, because is really hasn't changed much.
But I don't mind going to 2.0 if we want to be strict with the breaking=>major bump semantics.

@joanise joanise changed the title Dev.ej/219 bump web c Bring the bundled web-component up to date May 24, 2024
Copy link
Contributor

github-actions bot commented May 24, 2024

CLI load time: 0:00.05
Pull Request HEAD: 98d99e465138042f50552d88df08b215a2599a8b
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.17%. Comparing base (cab4da8) to head (98d99e4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #220   +/-   ##
=======================================
  Coverage   87.17%   87.17%           
=======================================
  Files          21       21           
  Lines        1762     1762           
  Branches      321      321           
=======================================
  Hits         1536     1536           
  Misses        189      189           
  Partials       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but I followed the steps you gave and got this:

image

@joanise
Copy link
Member Author

joanise commented Jun 4, 2024

@roedoejet I can't reproduce your error. My single-file HTML has this: audio="data:audio/mp4;base64,AAAAG... while your screen capture shows audio="data:audio/mp4a-latm;base64,AAAAG... could this be incompatible with a Mac? @marctessier any chance you can test this one your end?
Also, Aidan, do you get the same problem on origin/main? I suspect the issue is not related to this PR.

@joanise joanise merged commit 6ac285f into main Jun 5, 2024
6 checks passed
@joanise joanise deleted the dev.ej/219-bump-web-c branch June 5, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the fallback bundles in Studio CLI's readalongs/text/
3 participants