-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring the bundled web-component up to date #220
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #220 +/- ##
=======================================
Coverage 87.17% 87.17%
=======================================
Files 21 21
Lines 1762 1762
Branches 321 321
=======================================
Hits 1536 1536
Misses 189 189
Partials 37 37 ☔ View full report in Codecov by Sentry. |
d22a88e
to
98d99e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roedoejet I can't reproduce your error. My single-file HTML has this: |
PR Goal?
update the long stale web-component offline bundles, and current web-component version.
Fixes?
Fixes #219
Feedback sought?
just make sure it works OK
Priority?
normal
Tests added?
n/a
How to test?
run
cd test; readalongs align -o html data/ej-fra.txt data/ej-fra.m4a -l fra delme
and see that the single-file HTML in delme has the gear menu (i.e., the latest web-component version) andindex.html
asks for[email protected]
.Confidence?
high
Version change?
We're long overdue for a release, not for this PR but for previous changes, with at least a minor bump.
Significant changes:
Even though dropping Python 3.7 is a breaking change, I'd be inclined to just bump this project to 1.1, not 2.0, because is really hasn't changed much.
But I don't mind going to 2.0 if we want to be strict with the breaking=>major bump semantics.