-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: including generator meta tag in .readalong files #226
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
==========================================
+ Coverage 87.22% 87.24% +0.02%
==========================================
Files 21 21
Lines 1769 1772 +3
Branches 321 321
==========================================
+ Hits 1543 1546 +3
Misses 189 189
Partials 37 37 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ready for merge
Just discovered an issue while discussing #229, repeating the comment here since it's relevant here:
|
Also, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a new constant, as mentioned above, for format_version
.
test: fixing ci conflict resolution: VERSION is now only in readalongs/_version.py TODO: __version__ is no longer defined, and we need a FORMAT_VERSION
acdc9e9
to
9f3414e
Compare
Since I broke this code with my other PR, I rebased it for you and created the new variable. @deltork take a look and make sure it's OK. I'll approve, but it's also worth a re-review by someone else. @roedoejet ? |
|
||
|
||
if __name__ == "__main__": | ||
#!/usr/bin/env python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was in CRLF so I fixed that, hence this apparent whole file diff. Hide whitespace changes to view the real diff.
DONE |
Thanks for doing this
Looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My requested changes are done.
Rebased duplicate of #225 - please either close this one or close #225 and re-request the reviews here.