fix: fix (or attempt to fix) the pypi publication process #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
=======================================
Coverage 87.21% 87.21%
=======================================
Files 21 21
Lines 1783 1783
Branches 323 323
=======================================
Hits 1555 1555
Misses 189 189
Partials 39 39 ☔ View full report in Codecov by Sentry. |
joanise
commented
Sep 13, 2024
| - name: Publish distribution 📦 to PyPI | ||
| uses: pypa/gh-action-pypi-publish@release/v1 | ||
| with: | ||
| password: ${{ secrets.PYPI_API_TOKEN }} |
There was a problem hiding this comment.
Based on https://docs.pypi.org/trusted-publishers/ I bet we can (and should) remove this password field.
There was a problem hiding this comment.
But it works like this in g2p, so I'll leave it this way for now.
joanise
force-pushed
the
dev.ej/fix-pypi-publish
branch
from
6728456
to
56b5e1d
Compare
joanise
commented
Sep 17, 2024
| password: ${{ secrets.PYPI_API_TOKEN }} | ||
| verbose: true | ||
|
|
||
| deploy-docs: |
There was a problem hiding this comment.
follows what we do in g2p
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing works today. 🙁
Can't publish studio.
Finding last minutes bugs in studio-web.
Bleh.
Here, I'm guessing the way we published to pypi is no longer supported. See #240.
This code is mimicked from g2p, but not tested. Please review carefully.
Before this can work, we'll need to add the PYPI_API_TOKEN to this repo's secrets, and we can probably remove the obsolete PyPI username and password secrets since they don't work anymore anyway.