Issue#5

[abhijoshi2k]

Thank you for contributing! Please check the following things before submiting your PR:

Required:

• I have read and followed the contributing guidelines

If necessary:

• I have updated the README and documentation.
• I have updated the ChangeLog with the changes I have made.

Replace this line with a short description about the changes you have made in this PR e.g. Corrected spelling mistakes in docs

---

Note: we will close your PR without comment if you do not check the required boxes above and provide ALL requested information.

[welcome]

Thanks for opening this pull request! Make sure you have read the contributing guidelines, assigned an respective issue (if applicable) to this PR 😇

[abhijoshi2k]

@PuneetGopinath I still have to add other things. Will request review once it's done.

[PuneetGopinath]

Yes, No probs
@Andre601 can also help in adding this to readme

[abhijoshi2k]

@PuneetGopinath I've added the required customizations. But we need to check once by merging.
Once we have tested everything, we will add it to readme.

[PuneetGopinath]

@PuneetGopinath I've added the required customizations. But we need to check once by merging.
Once we have tested everything, we will add it to readme.

Sure

[abhijoshi2k]

@PuneetGopinath Please review and merge. Let me know if any changes are required.

[PuneetGopinath]

Can you run build?

[abhijoshi2k]

Can you run build?

Done

[PuneetGopinath]

Now last we have to add it to readme and changelog

[PuneetGopinath]

I will add to changelog, you can add to readme

[abhijoshi2k]

Now last we have to add it to readme and changelog

We need to test on our own repos first.

[abhijoshi2k]

Now last we have to add it to readme and changelog

We need to test on our own repos first.

For that we must merge. Should we?

[PuneetGopinath]

Yes, we have to merge branch main
But how can we test without merging this pr?

[abhijoshi2k]

Yes, we have to merge branch main
But how can we test without merging this pr?

We can change branch in our workflow. Currently it is main. We can change it to issue#5

[PuneetGopinath]

Ohh yes

[PuneetGopinath]

No need to release new version right?

[abhijoshi2k]

No need to release new version right?

Nope. We will release after testing

[abhijoshi2k]

I tried using issue#5 branch, but because of # it failed, So I used test branch (test branch also failed, should we change default ranch)

It worked for me.

[abhijoshi2k]

https://github.com/abhijoshi2k/abhijoshi2k/actions/runs/824759624
check this

[PuneetGopinath]

I tried using issue#5 branch, but because of # it failed, So I used test branch (test branch also failed, should we change default ranch)

It worked for me.

I made I mistake, anyway if it works, we can update readme, pull main and merge this pr

[PuneetGopinath]

Don't release after merging this pr, #4 has to be completed

[abhijoshi2k]

Don't release after merging this pr, #4 has to be completed

Okay. I'll update readme and merge. Will wait for release till #4 is completed.

[welcome]

Congrats on merging your first pull request🎉! We are proud of you!

[Andre601]

What about a {URL} option that would resolve into a URL?
Or do both {ID} and {REPO} resolve into linking to the issue/PR and Repo respectively? Kind of limiting if you ask me.

[abhijoshi2k]

What about a {URL} option that would resolve into a URL?
Or do both {ID} and {REPO} resolve into linking to the issue/PR and Repo respectively? Kind of limiting if you ask me.

{ID} and {REPO} both resolve into inking to the issue/PR and Repo respectively.
So clicking on those will take you to respective issue/PR and repository.

I don't understand what would be the use of {URL}

[Andre601]

What about a {URL} option that would resolve into a URL?
Or do both {ID} and {REPO} resolve into linking to the issue/PR and Repo respectively? Kind of limiting if you ask me.

{ID} and {REPO} both resolve into inking to the issue/PR and Repo respectively.
So clicking on those will take you to respective issue/PR and repository.

I don't understand what would be the use of {URL}

Was shown in my issue.
Essentially something like [`{REPO}#{ID}`]({URL}) which f.e. resolved into Readme-Workflows/recent-activity#11 would be possible.

[Andre601]

@Andre601 Can you give me an example output having {URL}?

{URL} would essentially do what {ID} and {REPO} do right now, which is directly linking to the issue, comment, PR

[abhijoshi2k]

@Andre601 That would be raw format. Such formats are difficult for users with less knowledge of markdown.
We can add it though. Then if the {URL} is mentioned, it'll be treated as raw markdown and workflow will just replace text as it is and add the issue/pr URL to it.
But if user formats f.e. COMMENTS_ACTIVITY in improper way, output will be some very weird string.
I don't know if I'm able to explain my concern properly.
I just want to say that it will be difficult for user to format this.

We can instead add 1 more parameter:
URL_FORMAT --> Will contain how {URL} will be replaced f.e. {REPO}{ID} will give same result as you earlier mentioned.

So user will only have to add {URL} and not [{REPO}#{ID}]({URL})

[Andre601]

We can instead add 1 more parameter:
URL_FORMAT --> Will contain how {URL} will be replaced f.e. {REPO}{ID} will give same result as you earlier mentioned.

So user will only have to add {URL} and not [{REPO}#{ID}]({URL})

That would be an idea.

[abhijoshi2k]

We can instead add 1 more parameter:
URL_FORMAT --> Will contain how {URL} will be replaced f.e. {REPO}{ID} will give same result as you earlier mentioned.
So user will only have to add {URL} and not [{REPO}#{ID}]({URL})

That would be an idea.

Okay. I'll work on it.