-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CCXDEV-12017] Use Github workflows to run CI tests and update Go version #649
Conversation
eb40a63
to
9b8b06a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd use the same Go version as is specified in Dockerfile
makes sense. Going with 1.18 then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
goimports
on all files (to make golangci-lint pass)whitespace linter
as fixing all the files seems to end up in a loop (will look into it in another PR)Fixes CCXDEV-12107
Type of change
Testing steps
CI (Github workflows) should pass
Checklist
make before_commit
passes