Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCXDEV-12017] Use Github workflows to run CI tests and update Go version #649

Merged
merged 7 commits into from
Oct 25, 2023

Conversation

epapbak
Copy link
Collaborator

@epapbak epapbak commented Oct 24, 2023

Description

  • Update Go version to 1.20 (maximum version supported by go tidy)
  • Remove Travis CI configuration file and replace to with corresponding Github workflows
  • Apply goimports on all files (to make golangci-lint pass)
  • Fix all issues detected by 'revive' linter (to make golangci-lint pass)
  • Remove whitespace linter as fixing all the files seems to end up in a loop (will look into it in another PR)

Fixes CCXDEV-12107

Type of change

  • Go version update
  • CI configuration update

Testing steps

CI (Github workflows) should pass

Checklist

  • make before_commit passes
  • updated documentation wherever necessary
  • added or modified tests if necessary
  • updated schemas and validators in insights-data-schemas in case of input/output change

@epapbak epapbak force-pushed the CCXDEV-12107 branch 7 times, most recently from eb40a63 to 9b8b06a Compare October 24, 2023 14:32
@epapbak epapbak changed the title [CCXDEV-12017] Use Github workflows to run CI tests instead of Travis CI [CCXDEV-12017] Use Github workflows to run CI tests and update Go version Oct 25, 2023
Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use the same Go version as is specified in Dockerfile

@epapbak
Copy link
Collaborator Author

epapbak commented Oct 25, 2023

I'd use the same Go version as is specified in Dockerfile

makes sense. Going with 1.18 then

Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisnik tisnik merged commit 8219475 into RedHatInsights:master Oct 25, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants