Navigation and avatar changes #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryelo
previously requested changes
Aug 31, 2020
src/js/App/Sidenav/Navigation.js
Outdated
| @@ -18,14 +18,14 @@ const openshiftLinks = { | |||
| link: 'https://access.redhat.com/support/cases' | |||
| }, | |||
| feedback: { | |||
| title: 'Cluster Manager Feedback', | |||
| title: 'Cluster Manager Feedback', | |||
src/js/App/Sidenav/Navigation.js
Outdated
| link: 'mailto:[email protected]' | ||
| }, | ||
| marketplace: { | ||
| title: 'Red Hat Marketplace', | ||
| link: 'https://marketplace.redhat.com' | ||
| } | ||
| }; | ||
| }; |
src/js/App/Header/UserToggle.js
Outdated
| @@ -79,10 +81,12 @@ export class UserToggle extends Component { | |||
| render() { | |||
| const { isOpen } = this.state; | |||
| const { account, isSmall, extraItems } = this.props; | |||
| const toggle = isSmall ? | |||
| const toggle = isSmall | |||
| ? | |||
src/sass/chrome.scss
Outdated
Comment on lines
98
to
102
| .ins-c-dropdown-icon { | ||
| height: 36px; | ||
| width: 36px; | ||
| } | ||
|
|
There was a problem hiding this comment.
Can you move this to a new file UserIcon.scss and import it in UserIcon.js?
src/sass/chrome.scss
Outdated
| @@ -106,6 +111,7 @@ aside { | |||
| .pf-c-page__header-tools .pf-c-avatar { | |||
| height: var(--pf-global--FontSize--4xl); | |||
| } | |||
|
|
|||
src/js/App/Header/UserIcon.js
Outdated
| @@ -26,7 +26,7 @@ export class UserIcon extends Component { | |||
| } | |||
|
|
|||
| render() { | |||
| const { avatar } = this.state; | |||
| const { avatar } = this.state; | |||
|
@arivepr You can run LGTM after these are fixed 😄 |
karelhala
reviewed
Sep 10, 2020
src/js/App/Header/Tools.js
Outdated
| @@ -1,17 +1,13 @@ | |||
| import React, { useState, useEffect } from 'react'; | |||
|
|
|||
| import { Button } from '@patternfly/react-core/dist/js/components/Button/Button'; | |||
| import { Button } from '@patternfly/react-core/dist`/js/components/Button/Button'; | |||
There was a problem hiding this comment.
Extra character
Suggested change
| import { Button } from '@patternfly/react-core/dist`/js/components/Button/Button'; | |
| import { Button } from '@patternfly/react-core/dist/js/components/Button/Button'; |
|
Remove the extra ` and update snapshots and we are golden! |
Codecov Report
@@ Coverage Diff @@
## master #942 +/- ##
=======================================
Coverage 52.58% 52.58%
=======================================
Files 53 53
Lines 1046 1046
Branches 212 212
=======================================
Hits 550 550
Misses 395 395
Partials 101 101
|
karelhala
approved these changes
Sep 10, 2020
|
@karelhala sorry I added the |
|
@ryelo too fast on the merge button 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to move in the changes made for cards 3085 and 8493.
The PF Avatar is now all integrated with the dropdown menu and "Documentation" link has been moved to the bottom of the nav.