feat: Capture blacklisted specs inside archive #3664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfahr
reviewed
Jan 24, 2023
ryan-blakley
force-pushed
the
capture_blacklisted_specs
branch
3 times, most recently
from
a4cafff
to
2f56b4e
Compare
bfahr
requested changes
Jan 31, 2023
ryan-blakley
force-pushed
the
capture_blacklisted_specs
branch
from
2f56b4e
to
9592ab3
Compare
|
@subpop When you get a chance if you could review the client code changes in this PR please. |
ryan-blakley
force-pushed
the
capture_blacklisted_specs
branch
from
9592ab3
to
6e9af3a
Compare
|
From what I can see, this doesn't appear to alter the client execution of the collection routine, so this should be fine. |
ryan-blakley
force-pushed
the
capture_blacklisted_specs
branch
from
6e9af3a
to
79d4f77
Compare
|
Awesome thank you for reviewing it. |
|
@kgrant-rh @jsvob Since y'alls team was the one who brought up the issue about not being able to tell if spec was blacklisted or not. When y'all have time if you could please review this PR, and let me know if these changes will help with that. |
* Capture the name of blacklisted specs, and dump them to a file in the archive. * Added parser and spec to parse the blacklisted specs and use in rules. Signed-off-by: Ryan Blakley <[email protected]>
ryan-blakley
force-pushed
the
capture_blacklisted_specs
branch
from
79d4f77
to
eac8230
Compare
|
@ryan-blakley Yes, LGTM, thank you. It can help with resolving #3527 eventually. |
xiangce
pushed a commit
that referenced
this pull request
Feb 6, 2023
* Capture the name of blacklisted specs, and dump them to a file in the archive. * Added parser and spec to parse the blacklisted specs and use in rules. Signed-off-by: Ryan Blakley <[email protected]> (cherry picked from commit da20d33)
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
* Capture the name of blacklisted specs, and dump them to a file in the archive. * Added parser and spec to parse the blacklisted specs and use in rules. Signed-off-by: Ryan Blakley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply:
Complete Description of Additions/Changes:
Capture the name of blacklisted specs, and dump them to a file in the archive. Added parser and spec to parse the blacklisted specs and use in rules.