fix: update Uname parser to fix LooseVersion comparision error #3814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinpingli
force-pushed
the
RHINRULE-198
branch
2 times, most recently
from
39939fd
to
e949e18
Compare
qinpingli
changed the title
|
@xiangce @chenlizhong please help review, thanks! |
qinpingli
force-pushed
the
RHINRULE-198
branch
4 times, most recently
from
1e2b25b
to
8842a7b
Compare
xiangce
requested changes
Aug 4, 2023
Exception: TypeError: '<' not supported between instances of 'str' and 'int' is returned when the fixed_by or introduced_in doesn't have distribution part in release and version and other release parts are the same as current kernel. The detailed update is not doing comparation the distribution part in release. Signed-off-by: Ping Qin <[email protected]>
When _lv_release in self and other both or neither have the distribution part, compare them directly. Otherwise, removing the distribution part first, then doing the comparation without the distribution part and raising a warning. Signed-off-by: Ping Qin <[email protected]>
@qinpingli - you may miss this comment? and btw, since a |
Signed-off-by: Ping Qin <[email protected]>
You are right! Sorry for missing it. Now, new test cases are added, please help take a look again, thanks! |
xiangce
reviewed
Aug 9, 2023
qinpingli
force-pushed
the
RHINRULE-198
branch
2 times, most recently
from
ffc8155
to
0da0096
Compare
xiangce
approved these changes
Aug 9, 2023
qinpingli
force-pushed
the
RHINRULE-198
branch
3 times, most recently
from
7aca83a
to
5c9cc3b
Compare
Signed-off-by: Ping Qin <[email protected]>
xiangce
pushed a commit
that referenced
this pull request
Aug 9, 2023
* fix: enhance Uname.fixed_by() Exception: TypeError: '<' not supported between instances of 'str' and 'int' is returned when the fixed_by or introduced_in doesn't have distribution part in release and version and other release parts are the same as current kernel. The detailed update is not doing comparation the distribution part in release. Signed-off-by: Ping Qin <[email protected]> * fix: Update Uname.fixed_by() When _lv_release in self and other both or neither have the distribution part, compare them directly. Otherwise, removing the distribution part first, then doing the comparation without the distribution part and raising a warning. Signed-off-by: Ping Qin <[email protected]> * fix: Add test for pad_release() and warnings in fixed_by() * fix: seperate the test cases for warnings in a different method Signed-off-by: Ping Qin <[email protected]> (cherry picked from commit 0862442)
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
* fix: enhance Uname.fixed_by() Exception: TypeError: '<' not supported between instances of 'str' and 'int' is returned when the fixed_by or introduced_in doesn't have distribution part in release and version and other release parts are the same as current kernel. The detailed update is not doing comparation the distribution part in release. Signed-off-by: Ping Qin <[email protected]> * fix: Update Uname.fixed_by() When _lv_release in self and other both or neither have the distribution part, compare them directly. Otherwise, removing the distribution part first, then doing the comparation without the distribution part and raising a warning. Signed-off-by: Ping Qin <[email protected]> * fix: Add test for pad_release() and warnings in fixed_by() * fix: seperate the test cases for warnings in a different method Signed-off-by: Ping Qin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed error is:
TypeError: '<' not supported between instances of 'str' and 'int'
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
The issue is: #3815