Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add spec and parser for etc_sysconfig_kernel #4221

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

JoySnow
Copy link
Collaborator

@JoySnow JoySnow commented Sep 24, 2024

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • No Sensitive Data in this change?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

This spec is added for a new advisor rule.

@xiangce
Copy link
Contributor

xiangce commented Sep 26, 2024

@JoySnow - Thanks for enhancing the coverage of the default module

@xiangce xiangce merged commit 9baadb4 into RedHatInsights:master Sep 26, 2024
17 checks passed
@JoySnow JoySnow deleted the spec-sysconf-kernel branch September 26, 2024 07:15
xiangce pushed a commit that referenced this pull request Sep 26, 2024
* feat: add spec and parser for etc_sysconfig_kernel

Signed-off-by: Xiaoxue Wang <[email protected]>

* fix: test coverage to 100% for insights/specs/default.py

Signed-off-by: Xiaoxue Wang <[email protected]>
(cherry picked from commit 9baadb4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants