Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ci/cd): add first-interaction action #4226

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

xiangce
Copy link
Contributor

@xiangce xiangce commented Sep 27, 2024

  • and guide the first-time contributor to read the CONTRIBUTING.md
  • RHINENG-12619

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • No Sensitive Data in this change?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

For first-time contributor, the following comment will be added automatically:


Greetings!

Thanks for contributing to insights-core.
To make sure your code is compliant with the guide, please go through the Contributing and review your code first.

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.69%. Comparing base (ae72675) to head (a76d334).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4226   +/-   ##
=======================================
  Coverage   76.69%   76.69%           
=======================================
  Files         759      759           
  Lines       41788    41788           
  Branches     9603     9603           
=======================================
  Hits        32051    32051           
  Misses       8638     8638           
  Partials     1099     1099           
Flag Coverage Δ
unittests 76.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangce xiangce changed the title test(ci/cd): add first-integration pipeline:w test(ci/cd): add first-integration action Sep 27, 2024
@xiangce xiangce force-pushed the first_integration branch 2 times, most recently from ab6c78d to 5292e8e Compare September 27, 2024 07:14
@xiangce xiangce added the WIP Includes: Approved but Not Ready for Merging/Releasing label Sep 27, 2024
@xiangce xiangce changed the title test(ci/cd): add first-integration action test(ci/cd): add first-interaction action Sep 27, 2024
…ghts#4232)

- when collecting in py26 env, if the foreach_execute specs depends
  on DatasourceProvider, the provider will be in unicode type and causes
  the followed validate() fail
- this change converted the unicode to string by force for all 'cmd' passed to
  CommandOutputProvider

Signed-off-by: Xiangce Liu <[email protected]>

rh-pre-commit.version: 2.3.1
rh-pre-commit.check-secrets: ENABLED
- and guide the first-time contributor to read
  the CONTRIBUTING.md
- RHINENG-12619

Signed-off-by: Xiangce Liu <[email protected]>
Signed-off-by: Xiangce Liu <[email protected]>

rh-pre-commit.version: 2.3.1
rh-pre-commit.check-secrets: ENABLED
@xiangce xiangce merged commit 6892a58 into RedHatInsights:master Sep 30, 2024
12 checks passed
@xiangce xiangce deleted the first_integration branch September 30, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Includes: Approved but Not Ready for Merging/Releasing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants