-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(ci/cd): add first-interaction action #4226
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4226 +/- ##
=======================================
Coverage 76.69% 76.69%
=======================================
Files 759 759
Lines 41788 41788
Branches 9603 9603
=======================================
Hits 32051 32051
Misses 8638 8638
Partials 1099 1099
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangce
changed the title
test(ci/cd): add first-integration pipeline:w
test(ci/cd): add first-integration action
Sep 27, 2024
xiangce
force-pushed
the
first_integration
branch
from
September 27, 2024 07:02
fbb5c9d
to
ae54f61
Compare
JoySnow
approved these changes
Sep 27, 2024
xiangce
force-pushed
the
first_integration
branch
2 times, most recently
from
September 27, 2024 07:14
ab6c78d
to
5292e8e
Compare
xiangce
force-pushed
the
first_integration
branch
from
September 27, 2024 07:31
5292e8e
to
8910271
Compare
xiangce
changed the title
test(ci/cd): add first-integration action
test(ci/cd): add first-interaction action
Sep 27, 2024
…ghts#4232) - when collecting in py26 env, if the foreach_execute specs depends on DatasourceProvider, the provider will be in unicode type and causes the followed validate() fail - this change converted the unicode to string by force for all 'cmd' passed to CommandOutputProvider Signed-off-by: Xiangce Liu <[email protected]> rh-pre-commit.version: 2.3.1 rh-pre-commit.check-secrets: ENABLED
- and guide the first-time contributor to read the CONTRIBUTING.md - RHINENG-12619 Signed-off-by: Xiangce Liu <[email protected]>
Signed-off-by: Xiangce Liu <[email protected]> rh-pre-commit.version: 2.3.1 rh-pre-commit.check-secrets: ENABLED
xiangce
force-pushed
the
first_integration
branch
from
September 30, 2024 03:28
8910271
to
230e8ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
For first-time contributor, the following comment will be added automatically:
Greetings!
Thanks for contributing to insights-core.
To make sure your code is compliant with the guide, please go through the Contributing and review your code first.