feat: add ceph specs 'ceph_v' and 'ceph_insights' to sos_archive #4233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
The combiner
insights.combiners.ceph_version.CephVersion
utilizes the following three parser classes:CephVersion
,CephInsights
, andCephReport
. Currently, in thesos_archive.py
, there is only one spec added for thesos_commands/ceph/ceph_report
file.In some sosreports, the
ceph_report
andceph_insights
files may contain errors instead of valid data. This issue causes the GSS rule to be skipped because the required version information is not retrieved. In such cases, theceph_-v
file contains the necessary version information. By adding the relevant specs, the GSS rule will not be skipped, ensuring a successful hit.