Update malware-detection tests for different version of yara #4235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Versions of yara >= 4.5.x produce slightly different results to earlier versions Signed-off-by: Mark Huth <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4235 +/- ##
=======================================
Coverage 76.88% 76.88%
=======================================
Files 757 757
Lines 41342 41342
Branches 9526 9526
=======================================
+ Hits 31785 31787 +2
+ Misses 8479 8478 -1
+ Partials 1078 1077 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Versions of yara 4.5.x and later change/fix the fast-scan option and produce different results than earlier versions. This PR updates the malware-detection tests so they work with both versions before and after version 4.5.x.
This PR doesn't affect the functionality of malware-detection in any way. It just modifies some of the unittests. And even then, the modified unittests only run if yara is actually installed on system running the tests.